Skip to content

[SPARK-22437][PYSPARK] default mode for jdbc is wrongly set to None#19654

Closed
mgaido91 wants to merge 1 commit intoapache:masterfrom
mgaido91:SPARK-22437
Closed

[SPARK-22437][PYSPARK] default mode for jdbc is wrongly set to None#19654
mgaido91 wants to merge 1 commit intoapache:masterfrom
mgaido91:SPARK-22437

Conversation

@mgaido91
Copy link
Contributor

@mgaido91 mgaido91 commented Nov 3, 2017

What changes were proposed in this pull request?

When writing using jdbc with python currently we are wrongly assigning by default None as writing mode. This is due to wrongly calling mode on the _jwrite object instead of self and it causes an exception.

How was this patch tested?

manual tests

@mgaido91
Copy link
Contributor Author

mgaido91 commented Nov 3, 2017

I think that the failure is an infra issue..

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

retest this please

1 similar comment
@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Nov 3, 2017

Test build #83416 has finished for PR 19654 at commit dd52769.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in e7adb7d Nov 4, 2017
@mgaido91 mgaido91 deleted the SPARK-22437 branch November 4, 2017 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants