[SPARK-21127][SQL][followup] fix a config name typo #19667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #83482 has finished for PR 19667 at commit
|
wzhfy
reviewed
Nov 7, 2017
| @@ -812,8 +812,8 @@ object SQLConf { | |||
| .doubleConf | |||
| .createWithDefault(0.05) | |||
|
|
|||
| val AUTO_UPDATE_SIZE = | |||
| buildConf("spark.sql.statistics.autoUpdate.size") | |||
| val AUTO_UPDATE_ENABLED = | |||
Contributor
There was a problem hiding this comment.
How about AUTO_UPDATE_SIZE_ENABLED? If we support auto update other stats (needs table scan in addition to just looking up file length) in the future, we may need another config.
|
Test build #83537 has finished for PR 19667 at commit
|
Member
|
LGTM Thanks! Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
spark.sql.statistics.autoUpdate.sizeshould bespark.sql.statistics.size.autoUpdate.enabled. The previous name is confusing as users may treat it as a size config.This config is in master branch only, no backward compatibility issue.
How was this patch tested?
N/A