[SPARK-22581][SQL] Catalog api does not allow to specify partitioning columns with create(external)table#19796
Closed
timvw wants to merge 4 commits intoapache:masterfrom
timvw:master
Closed
[SPARK-22581][SQL] Catalog api does not allow to specify partitioning columns with create(external)table#19796timvw wants to merge 4 commits intoapache:masterfrom timvw:master
timvw wants to merge 4 commits intoapache:masterfrom
timvw:master
Conversation
…. all we want to know is whether the columns are correctly recognized as partition columns
|
Can one of the admins verify this patch? |
wangyum
reviewed
Nov 3, 2018
| test("createTable with partition columns", Tag("go")) { | ||
| withTable("t") { | ||
| withTempDir { dir => | ||
| spark.catalog.createTable( |
Member
There was a problem hiding this comment.
May be you need spark.sessionState.catalog.createTable?
gatorsmile
reviewed
Nov 4, 2018
| source: String, | ||
| schema: StructType, | ||
| options: Map[String, String], | ||
| partitionColumnNames : Seq[String]): DataFrame |
Member
There was a problem hiding this comment.
I think we will not introduce a new API for partitioning columns in the current stage. Let us use SQL DDL for creating the table.
Contributor
Author
There was a problem hiding this comment.
Imho, having an API without options to specify partitioning in a big-data context is just pointless.
=> When looking at https://docs.google.com/document/d/1zLFiA1VuaWeVxeTDXNg8bL6GP3BVoOZBkewFtEnjEoo/edit# I get the feeling that API changes are coming, just not in the current stage. Fine with me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enhance Catalog api such that partition columns can be specified on createTable method
How was this patch tested?
Added a test to verify that the created table indeed has added a partition column