Skip to content

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Dec 29, 2017

What changes were proposed in this pull request?

This is a follow-up pr of #19587.

If xmlrunner is installed, VectorizedUDFTests.test_vectorized_udf_check_config fails by the following error because the self which is a subclass of unittest.TestCase in the UDF check_records_per_batch can't be pickled anymore.

PicklingError: Cannot pickle files that are not opened for reading: w

This changes the UDF not to refer the self.

How was this patch tested?

Tested locally.

@SparkQA
Copy link

SparkQA commented Dec 29, 2017

Test build #85506 has finished for PR 20115 at commit f078fe6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I saw this. LGTM if the tests pass.

@HyukjinKwon
Copy link
Member

Merged to master

@asfgit asfgit closed this in 11a849b Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants