Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test failure when xmlrunner is installed. #20115

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@ueshin
Copy link
Member

commented Dec 29, 2017

What changes were proposed in this pull request?

This is a follow-up pr of #19587.

If xmlrunner is installed, VectorizedUDFTests.test_vectorized_udf_check_config fails by the following error because the self which is a subclass of unittest.TestCase in the UDF check_records_per_batch can't be pickled anymore.

PicklingError: Cannot pickle files that are not opened for reading: w

This changes the UDF not to refer the self.

How was this patch tested?

Tested locally.

@SparkQA

This comment has been minimized.

Copy link

commented Dec 29, 2017

Test build #85506 has finished for PR 20115 at commit f078fe6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@HyukjinKwon
Copy link
Member

left a comment

Yea I saw this. LGTM if the tests pass.

@HyukjinKwon

This comment has been minimized.

Copy link
Member

commented Dec 29, 2017

Merged to master

@asfgit asfgit closed this in 11a849b Dec 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.