-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-23059][SQL][TEST] Correct some improper with view related method usage #20250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dongjoon-hyun Please review it. |
|
@dongjoon-hyun @gatorsmile Please review it. thanks |
|
ok to test |
|
Test build #86134 has finished for PR 20250 at commit
|
jiangxb1987
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| assert(spark.catalog.listTables(globalTempDB).collect().toSeq.map(_.name) == Seq("v1", "v2")) | ||
| } finally { | ||
| spark.catalog.dropTempView("v1") | ||
| spark.catalog.dropGlobalTempView("v2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
Retest this please. |
|
Test build #86347 has finished for PR 20250 at commit
|
|
@gatorsmile @jiangxb1987 @dongjoon-hyun Can this PR be merged ? I will fix if it has problem |
|
retest this please |
|
Test build #86748 has finished for PR 20250 at commit
|
|
Thanks! Merged to master |
|
Thanks. |
What changes were proposed in this pull request?
Correct some improper with view related method usage
Only change test cases
like:
other change please review the code.
How was this patch tested?
See test case.