[SPARK-23039][SQL] Finish TODO work in alter table set location. #20260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TOBO work: Fix the bug in alter table set location.
org.apache.spark.sql.execution.command.DDLSuite#testSetLocation
// TODO(gatorsmile): fix the bug in alter table set location.
// if (isUsingHiveMetastore) {
// assert(storageFormat.properties.get("path") === expected)
// }
Contributor
Author
|
@gatorsmile Please review it. This is your TODO work. Please check it. |
Member
|
ok to test |
|
Test build #86103 has finished for PR 20260 at commit
|
Contributor
Author
|
I will fix the error of this PR after #20249 (comment) merged |
Contributor
|
@xubo245 please close this if the other PR supersedes. |
Contributor
Author
|
This PR is different |
Member
| val tableLocation = getLocationFromStorageProps(table) | ||
| // We pass None as `newPath` here, to remove the path option in storage properties. | ||
| updateLocationInStorageProps(table, newPath = None).copy( | ||
| table.storage.copy( |
Member
There was a problem hiding this comment.
In the comments above:
// Internally we store the table location in storage properties with key "path" for data
// source tables. Here we set the table location to `locationUri` field and filter out the
// path option in storage properties, to avoid exposing this concept externally.
// We pass None as `newPath` here, to remove the path option in storage properties.
The property path is removed intentionally.
To finish to a TODO comment in unit test is not a good reason to keep it.
Contributor
Author
There was a problem hiding this comment.
So we should remove the TODO comment/work?
|
Can one of the admins verify this patch? |
Member
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Finish TODO work in alter table set location.
org.apache.spark.sql.execution.command.DDLSuite#testSetLocation
fix it by remove newPath = None in org.apache.spark.sql.hive.HiveExternalCatalog#restoreDataSourceTable
How was this patch tested?
test("SPARK-23039: check path after SET LOCATION")
Wait for #20249