Skip to content

[SPARK-3135] Avoid extra mem copy in TorrentBroadcast via ByteArrayChunkOutputStream#2054

Closed
rxin wants to merge 6 commits intoapache:masterfrom
rxin:ByteArrayChunkOutputStream
Closed

[SPARK-3135] Avoid extra mem copy in TorrentBroadcast via ByteArrayChunkOutputStream#2054
rxin wants to merge 6 commits intoapache:masterfrom
rxin:ByteArrayChunkOutputStream

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Aug 20, 2014

This also enables supporting broadcast variables larger than 2G.

@rxin rxin changed the title [SPARK-3135] Created ByteArrayChunkOutputStream and used it to avoid mem copy in TorrentBroadcast. [SPARK-3135] Created ByteArrayChunkOutputStream and used it to avoid extra mem copy in TorrentBroadcast. Aug 20, 2014
@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have started for PR 2054 at commit ee88e73.

  • This patch merges cleanly.

@rxin rxin changed the title [SPARK-3135] Created ByteArrayChunkOutputStream and used it to avoid extra mem copy in TorrentBroadcast. [SPARK-3135] Avoid extra mem copy in TorrentBroadcast via ByteArrayChunkOutputStream Aug 20, 2014
@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have finished for PR 2054 at commit ee88e73.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ByteArrayChunkOutputStream(chunkSize: Int) extends OutputStream

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have started for PR 2054 at commit 93f5a51.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have finished for PR 2054 at commit 93f5a51.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to remove this line

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have started for PR 2054 at commit 618d9c8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have finished for PR 2054 at commit 618d9c8.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ByteArrayChunkOutputStream(chunkSize: Int) extends OutputStream

@rxin
Copy link
Contributor Author

rxin commented Aug 21, 2014

Updated & tests passed.

@rxin
Copy link
Contributor Author

rxin commented Sep 2, 2014

Merging this in master. Thanks for looking at it.

@asfgit asfgit closed this in db16067 Sep 2, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
…unkOutputStream

This also enables supporting broadcast variables larger than 2G.

Author: Reynold Xin <rxin@apache.org>

Closes apache#2054 from rxin/ByteArrayChunkOutputStream and squashes the following commits:

618d9c8 [Reynold Xin] Code review.
93f5a51 [Reynold Xin] Added comments.
ee88e73 [Reynold Xin] to -> until
bbd1cb1 [Reynold Xin] Renamed a variable.
36f4d01 [Reynold Xin] Sort imports.
8f1a8eb [Reynold Xin] [SPARK-3135] Created ByteArrayChunkOutputStream and used it to avoid memory copy in TorrentBroadcast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants