[SPARK-23602][SQL] PrintToStderr prints value also in interpreted mode#20773
Closed
mgaido91 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-23602][SQL] PrintToStderr prints value also in interpreted mode#20773mgaido91 wants to merge 3 commits intoapache:masterfrom
mgaido91 wants to merge 3 commits intoapache:masterfrom
Conversation
hvanhovell
reviewed
Mar 8, 2018
|
|
||
| test("PrintToStderr") { | ||
| val errorStream = new java.io.ByteArrayOutputStream() | ||
| val systemErr = System.err |
Contributor
There was a problem hiding this comment.
Can you wrap setting the stderr in a try { ... } finally { ... }?
hvanhovell
reviewed
Mar 8, 2018
| val outputEval = errorStream.toString | ||
| errorStream.reset() | ||
| // check with codegen | ||
| checkEvaluationWithoutCodegen(PrintToStderr(inputExpr), 1) |
Contributor
There was a problem hiding this comment.
checkEvaluationWithoutCodegen? Shouldn't we use checkEvaluationWithUnsafeProjection or checkEvaluationWithGeneratedMutableProjection?
hvanhovell
approved these changes
Mar 8, 2018
Contributor
hvanhovell
left a comment
hvanhovell
left a comment
There was a problem hiding this comment.
LGTM - pending jenkins.
|
Test build #88095 has finished for PR 20773 at commit
|
Contributor
|
retest this please |
|
Test build #88096 has finished for PR 20773 at commit
|
|
Test build #88098 has finished for PR 20773 at commit
|
Contributor
|
Merging to master. Thanks! |
|
Test build #88102 has finished for PR 20773 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PrintToStderrwas doing what is it supposed to only when code generation is enabled.The PR adds the same behavior in interpreted mode too.
How was this patch tested?
added UT