[SPARK-23700][PYTHON] Cleanup imports in pyspark.sql #20892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@HyukjinKwon, @holdenk @ueshin I tried to be pretty conservative and only remove imports that were obviously not being used. |
BryanCutler
commented
Mar 23, 2018
| from pyspark.sql.dataframe import DataFrame | ||
| from pyspark.sql.types import StringType, DataType | ||
| # Keep UserDefinedFunction import for backwards compatible import; moved in SPARK-22409 | ||
| from pyspark.sql.udf import UserDefinedFunction, _create_udf |
Member
Author
There was a problem hiding this comment.
Not sure if there is a better way to do this other than importing UserDefinedFunction here, but hopefully the note will show the intent.
Member
There was a problem hiding this comment.
yea, I think we should better keep this import and the comment looks good.
|
Test build #88547 has finished for PR 20892 at commit
|
Member
Author
|
Jenkins retest this please |
|
Test build #88549 has finished for PR 20892 at commit
|
felixcheung
approved these changes
Mar 24, 2018
Member
|
Merged to master. |
Member
Author
|
Thanks @felixcheung and @HyukjinKwon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This cleans up unused imports, mainly from pyspark.sql module. Added a note in function.py that imports
UserDefinedFunctiononly to maintain backwards compatibility for usingfrom pyspark.sql.function import UserDefinedFunction.How was this patch tested?
Existing tests and built docs.