Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23780][R] Failed to use googleVis library with new SparkR #21315

Closed
wants to merge 1 commit into from

Conversation

@felixcheung
Copy link
Member

commented May 13, 2018

What changes were proposed in this pull request?

change generic to get it to work with googleVis
also fix lintr

How was this patch tested?

manual test, unit tests

fix lintr
@felixcheung

This comment has been minimized.

@SparkQA

This comment has been minimized.

Copy link

commented May 13, 2018

Test build #90559 has finished for PR 21315 at commit 739ca64.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@felixcheung

This comment has been minimized.

Copy link
Member Author

commented May 13, 2018

@shivaram

This comment has been minimized.

Copy link
Contributor

commented May 13, 2018

LGTM. Lets wait till #21314 is merged ?

asfgit pushed a commit that referenced this pull request May 15, 2018
## What changes were proposed in this pull request?

change generic to get it to work with googleVis
also fix lintr

## How was this patch tested?

manual test, unit tests

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes #21315 from felixcheung/googvis.

(cherry picked from commit 9059f1e)
Signed-off-by: Felix Cheung <felixcheung@apache.org>
@felixcheung

This comment has been minimized.

Copy link
Member Author

commented May 15, 2018

merged to master/2.3

@asfgit asfgit closed this in 9059f1e May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.