[SPARK-24797] [SQL] respect spark.sql.hive.convertMetastoreOrc/Parquet when build… #21757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the data source table
CodingCat
changed the title
Contributor
Author
|
Test build #92960 has finished for PR 21757 at commit
|
gatorsmile
reviewed
Jul 13, 2018
| case i @ InsertIntoTable(UnresolvedCatalogRelation(tableMeta), _, _, _, _) | ||
| if DDLUtils.isDatasourceTable(tableMeta) => | ||
| if DDLUtils.isDatasourceTable(tableMeta) && | ||
| DDLUtils.convertSchema(tableMeta, sparkSession) => |
Member
There was a problem hiding this comment.
I do not think this is a right fix. If the original table is the native data source table, we will always use our parquet/orc reader instead of hive serde.
Contributor
Author
There was a problem hiding this comment.
do you mean any table built through df.write.format("..") should be taken as a data source table no matter we register it with HMS or not
Member
There was a problem hiding this comment.
If you are using format("parquet") to create a new table, it will be a data source table. We always use the native reader/writer to read/write such a table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
the current code path ignore the value of spark.sql.hive.convertMetastoreParquet when building data source table
spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
Line 263 in e0559f2
as a result, even I turned off spark.sql.hive.convertMetastoreParquet, Spark SQL still uses its own parquet reader to access table instead of delegate to serder
This PR checks the value of the configuration when building data source table
How was this patch tested?
existing test