[Minor][ML]Add UT for checking maximum number of features in the GeneralizedLinearRegression.. #21842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alizedLinearRegression and WeightedLeastSquares Currently GeneralizedLinearRegression and WeightedLeastSquare doesn't support features more than 4096. But there is no UT added to check this. In this PR, I have added UT for checking the behaviour of both the algorithms, if the features are more than 4096.
shahidki31
changed the title
|
Can one of the admins verify this patch? |
shahidki31
changed the title
Contributor
Author
|
closing as it is a minor PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..and WeightedLeastSquares
Currently in the GeneralizedLinearRegression and WeightedLeastSquares algorithms in spark doesn't support more than 4096 features. But there is no UT added to check this. In this PR, I have added UT for checking the behavior of both the algorithms, if the features are more than 4096.
How was this patch tested?
Added UT