Skip to content

[SPARK-24963][K8S][TESTS] Add user-specified service account name for client mode test driver pod#21924

Closed
mccheah wants to merge 1 commit intoapache:masterfrom
palantir:fix-service-account
Closed

[SPARK-24963][K8S][TESTS] Add user-specified service account name for client mode test driver pod#21924
mccheah wants to merge 1 commit intoapache:masterfrom
palantir:fix-service-account

Conversation

@mccheah
Copy link
Copy Markdown
Contributor

@mccheah mccheah commented Jul 30, 2018

What changes were proposed in this pull request?

Adds the user-set service account name for the driver pod in the client mode integration test

How was this patch tested?

Manual test against a custom Kubernetes cluster

@mccheah
Copy link
Copy Markdown
Contributor Author

mccheah commented Jul 30, 2018

@skonto can you sign off here before I merge?

@mccheah
Copy link
Copy Markdown
Contributor Author

mccheah commented Jul 30, 2018

ok to test

@SparkQA
Copy link
Copy Markdown

SparkQA commented Jul 30, 2018

@SparkQA
Copy link
Copy Markdown

SparkQA commented Jul 30, 2018

Test build #93808 has finished for PR 21924 at commit 8afc4e9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Jul 30, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1502/

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Jul 30, 2018

LGTM. I have the same change locally and it works.
I test like this:

./dev/dev-run-integration-tests.sh --service-account spark-sa --namespace spark --image-tag $SPARK_K8S_IMAGE_TAG --spark-tgz $TGZ_PATH --image-repo $DOCKER_USERNAME

@asfgit asfgit closed this in 2fbe294 Jul 30, 2018
@robert3005 robert3005 deleted the fix-service-account branch August 11, 2018 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants