Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

Use ASM 6 APIs after we upgrading it to ASM6.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @dbtsai @srowen

@kiszk
Copy link
Member

kiszk commented Aug 12, 2018

LGTM

@SparkQA
Copy link

SparkQA commented Aug 12, 2018

Test build #94639 has finished for PR 22082 at commit 2666500.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change just updates code to actually use ASM6 in these places? OK, pending tests.

@SparkQA
Copy link

SparkQA commented Aug 12, 2018

Test build #94643 has finished for PR 22082 at commit 2666500.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member

dbtsai commented Aug 12, 2018

retest this please

@dbtsai
Copy link
Member

dbtsai commented Aug 12, 2018

LGTM. @gatorsmile out of my curiosity, did you run into any issue that asm6 generates older version of bytecode defined in asm5?

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Aug 13, 2018

Test build #94660 has finished for PR 22082 at commit 2666500.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member

dbtsai commented Aug 13, 2018

Merged into master. Thanks.

@asfgit asfgit closed this in a992827 Aug 13, 2018
@gatorsmile
Copy link
Member Author

@dbtsai Nope. I did not hit any issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants