-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-24420][Build][FOLLOW-UP] Upgrade ASM6 APIs #22082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM |
|
Test build #94639 has finished for PR 22082 at commit
|
|
retest this please |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change just updates code to actually use ASM6 in these places? OK, pending tests.
|
Test build #94643 has finished for PR 22082 at commit
|
|
retest this please |
|
LGTM. @gatorsmile out of my curiosity, did you run into any issue that asm6 generates older version of bytecode defined in asm5? |
|
retest this please |
|
Test build #94660 has finished for PR 22082 at commit
|
|
Merged into master. Thanks. |
|
@dbtsai Nope. I did not hit any issue. :) |
What changes were proposed in this pull request?
Use ASM 6 APIs after we upgrading it to ASM6.
How was this patch tested?
N/A