SPARK-3318: Documentation update in addFile on how to use SparkFiles.get#2210
Closed
holdenk wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
…fy filename rather than path
Contributor
|
Looks good, thanks! |
Contributor
|
Actually you missed JavaSparkContext; it has the same issue |
Contributor
|
(And please add [SPARK-3318] at the beginning of your PR title) |
holdenk
changed the title
…leName with SparkFiles as well
Contributor
Author
|
@mateiz Thanks, completely forgot to check the javadoc. |
Contributor
|
Alright, thanks. Going to merge this. |
|
QA tests have started for PR 2210 at commit
|
|
QA tests have finished for PR 2210 at commit
|
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Rather than specifying the path to SparkFiles we need to use the filename. Author: Holden Karau <holden@pigscanfly.ca> Closes apache#2210 from holdenk/SPARK-3318-documentation-for-addfiles-should-say-to-use-file-not-path and squashes the following commits: a25d27a [Holden Karau] Update the JavaSparkContext addFile method to be clear about using fileName with SparkFiles as well 0ebcb05 [Holden Karau] Documentation update in addFile on how to use SparkFiles.get to specify filename rather than path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than specifying the path to SparkFiles we need to use the filename.