[SPARK-3345] Do correct parameters for ShuffleFileGroup#2235
Closed
viirya wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-3345] Do correct parameters for ShuffleFileGroup#2235viirya wants to merge 1 commit intoapache:masterfrom
viirya wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@viirya Good catch, thanks! Jenkins, test this please. |
Contributor
|
ok to test. Great catch, and LGTM if tests pass (they should...) |
|
QA tests have started for PR 2235 at commit
|
|
QA tests have finished for PR 2235 at commit
|
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
In the method `newFileGroup` of class `FileShuffleBlockManager`, the parameters for creating new `ShuffleFileGroup` object is in wrong order. Because in current codes, the parameters `shuffleId` and `fileId` are not used. So it doesn't cause problem now. However it should be corrected for readability and avoid future problem. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes apache#2235 from viirya/correct_shufflefilegroup_params and squashes the following commits: fe72567 [Liang-Chi Hsieh] Do correct parameters for ShuffleFileGroup.
asfgit
pushed a commit
that referenced
this pull request
Sep 9, 2014
In the method `newFileGroup` of class `FileShuffleBlockManager`, the parameters for creating new `ShuffleFileGroup` object is in wrong order. Because in current codes, the parameters `shuffleId` and `fileId` are not used. So it doesn't cause problem now. However it should be corrected for readability and avoid future problem. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes #2235 from viirya/correct_shufflefilegroup_params and squashes the following commits: fe72567 [Liang-Chi Hsieh] Do correct parameters for ShuffleFileGroup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the method
newFileGroupof classFileShuffleBlockManager, the parameters for creating newShuffleFileGroupobject is in wrong order.Because in current codes, the parameters
shuffleIdandfileIdare not used. So it doesn't cause problem now. However it should be corrected for readability and avoid future problem.