[SPARK-24157][SS][FOLLOWUP] Rename to spark.sql.streaming.noDataMicroBatches.enabled#22476
Closed
rxin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-24157][SS][FOLLOWUP] Rename to spark.sql.streaming.noDataMicroBatches.enabled#22476rxin wants to merge 1 commit intoapache:masterfrom
rxin wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Member
|
nit. Could you update the title |
rxin
changed the title
Contributor
Author
|
done |
Contributor
|
LGTM. |
|
Test build #96297 has finished for PR 22476 at commit
|
Contributor
Author
|
Merged in master/2.4. |
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2018
…Batches.enabled
## What changes were proposed in this pull request?
This patch changes the config option `spark.sql.streaming.noDataMicroBatchesEnabled` to `spark.sql.streaming.noDataMicroBatches.enabled` to be more consistent with rest of the configs. Unfortunately there is one streaming config called `spark.sql.streaming.metricsEnabled`. For that one we should just use a fallback config and change it in a separate patch.
## How was this patch tested?
Made sure no other references to this config are in the code base:
```
> git grep "noDataMicro"
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: buildConf("spark.sql.streaming.noDataMicroBatches.enabled")
```
Closes #22476 from rxin/SPARK-24157.
Authored-by: Reynold Xin <rxin@databricks.com>
Signed-off-by: Reynold Xin <rxin@databricks.com>
(cherry picked from commit 936c920)
Signed-off-by: Reynold Xin <rxin@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch changes the config option
spark.sql.streaming.noDataMicroBatchesEnabledtospark.sql.streaming.noDataMicroBatches.enabledto be more consistent with rest of the configs. Unfortunately there is one streaming config calledspark.sql.streaming.metricsEnabled. For that one we should just use a fallback config and change it in a separate patch.How was this patch tested?
Made sure no other references to this config are in the code base: