[SPARK-25727][FOLLOWUP] Move outputOrdering to case class field for InMemoryRelation#22726
Closed
mgaido91 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-25727][FOLLOWUP] Move outputOrdering to case class field for InMemoryRelation#22726mgaido91 wants to merge 1 commit intoapache:masterfrom
mgaido91 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Test build #97392 has finished for PR 22726 at commit
|
gatorsmile
reviewed
Oct 15, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
Thanks! For such a refactoring, I am unable to merge this to the 2.4 branch.
LGTM
Merged to master.
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…nMemoryRelation ## What changes were proposed in this pull request? The PR addresses [the comment](apache#22715 (comment)) in the previous one. `outputOrdering` becomes a field of `InMemoryRelation`. ## How was this patch tested? existing UTs Closes apache#22726 from mgaido91/SPARK-25727_followup. Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR addresses the comment in the previous one.
outputOrderingbecomes a field ofInMemoryRelation.How was this patch tested?
existing UTs