[SPARK-25791][SQL] Datatype of serializers in RowEncoder should be accessible #22785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #97674 has finished for PR 22785 at commit
|
|
Test build #97676 has finished for PR 22785 at commit
|
Member
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Oct 22, 2018
| val schema = new StructType().add("pythonUDT", pythonUDT, true) | ||
| val encoder = RowEncoder(schema) | ||
| // scalastyle:off println | ||
| encoder.serializer.foreach(s => println(s.dataType)) |
Contributor
There was a problem hiding this comment.
we shouldn't print in a test, can we use assert?
cloud-fan
reviewed
Oct 22, 2018
| if (inputObject.nullable) { | ||
| If(IsNull(inputObject), | ||
| Literal.create(null, inputType), | ||
| Literal.create(null, nonNullOutput.dataType), |
Contributor
There was a problem hiding this comment.
I see, for this case it has no difference, but makes the code clearer
cloud-fan
reviewed
Oct 22, 2018
| If( | ||
| Invoke(inputObject, "isNullAt", BooleanType, Literal(index) :: Nil), | ||
| Literal.create(null, field.dataType), | ||
| Literal.create(null, fieldValue.dataType), |
Contributor
There was a problem hiding this comment.
can we add a comment to explain it? field.dataType can be different from fieldValue.dataType, because we strip UDT
cloud-fan
reviewed
Oct 22, 2018
|
|
||
| test("SPARK-25791: Datatype of serializers should be accessible") { | ||
| val udtSQLType = new StructType().add("a", IntegerType) | ||
| val pythonUDT = new PythonUserDefinedType(udtSQLType, "pyUDT", "serializedPyClass") |
Contributor
There was a problem hiding this comment.
can we reproduce the bug with normal UDT?
Member
Author
There was a problem hiding this comment.
For normal UDT, we create an Invoke with the original udt type. So it won't cause such problem.
|
Test build #97915 has finished for PR 22785 at commit
|
Contributor
|
thanks, merging to master! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…cessible ## What changes were proposed in this pull request? The serializers of `RowEncoder` use few `If` Catalyst expression which inherits `ComplexTypeMergingExpression` that will check input data types. It is possible to generate serializers which fail the check and can't to access the data type of serializers. When producing If expression, we should use the same data type at its input expressions. ## How was this patch tested? Added test. Closes apache#22785 from viirya/SPARK-25791. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The serializers of
RowEncoderuse fewIfCatalyst expression which inheritsComplexTypeMergingExpressionthat will check input data types.It is possible to generate serializers which fail the check and can't to access the data type of serializers. When producing If expression, we should use the same data type at its input expressions.
How was this patch tested?
Added test.