Skip to content

Conversation

@felixcheung
Copy link
Member

What changes were proposed in this pull request?

Remove non-public internal only methods for RDD in SparkR

How was this patch tested?

Jenkins

@SparkQA
Copy link

SparkQA commented Oct 28, 2018

Test build #98148 has finished for PR 22866 at commit b16de30.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 28, 2018

Test build #98149 has finished for PR 22866 at commit 78f47e8.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 28, 2018

Test build #98150 has finished for PR 22866 at commit ba37a8a.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 28, 2018

Test build #98152 has finished for PR 22866 at commit 6fc37f2.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 28, 2018

Test build #98153 has finished for PR 22866 at commit 00ae00a.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung felixcheung changed the title [SPARK-12172][SPARKR] Remove internal-only RDD methods WIP [SPARK-12172][SPARKR] Remove internal-only RDD methods Oct 28, 2018
@SparkQA
Copy link

SparkQA commented Nov 11, 2018

Test build #98703 has finished for PR 22866 at commit d1f622e.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgment on this one.

@felixcheung
Copy link
Member Author

thx, but DO NOT MERGE - there's some nasty bug I'm still investigating..

@srowen
Copy link
Member

srowen commented Sep 16, 2019

@felixcheung where did you end up on this one?

@felixcheung
Copy link
Member Author

sorry, didn't get a chance to follow up. Since this is a big change, I might need to revert part of it to see what is leading to some implicit type conversion type of problem, IIRC. I will try to get back in a week.

@dongjoon-hyun
Copy link
Member

Hi, @felixcheung . Do you think we can have this at 3.0.0~?

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Feb 24, 2020
@github-actions github-actions bot closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants