-
Notifications
You must be signed in to change notification settings - Fork 29.1k
WIP [SPARK-12172][SPARKR] Remove internal-only RDD methods #22866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #98148 has finished for PR 22866 at commit
|
|
Test build #98149 has finished for PR 22866 at commit
|
|
Test build #98150 has finished for PR 22866 at commit
|
|
Test build #98152 has finished for PR 22866 at commit
|
|
Test build #98153 has finished for PR 22866 at commit
|
|
Test build #98703 has finished for PR 22866 at commit
|
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust your judgment on this one.
|
thx, but DO NOT MERGE - there's some nasty bug I'm still investigating.. |
|
@felixcheung where did you end up on this one? |
|
sorry, didn't get a chance to follow up. Since this is a big change, I might need to revert part of it to see what is leading to some implicit type conversion type of problem, IIRC. I will try to get back in a week. |
|
Hi, @felixcheung . Do you think we can have this at 3.0.0~? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
Remove non-public internal only methods for RDD in SparkR
How was this patch tested?
Jenkins