[Docs] Added csv, orc, and text output format options to DataFrameWriter doc string #23085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Since it's a trivial doc change, I didn't make a Jira ticket. Please let me know if there are any changes required. |
|
Can one of the admins verify this patch? |
Member
|
I think it doesn't need to change. It's likely to be changed and we wouldn't want to update this doc everytime we add new datasource. |
Member
|
It's already documented in official site anyway. |
Author
|
Why wouldn't you update the documentation to allow users to understand what file formats they can use? It's really bad practice for users to read source code. |
Member
|
Because it's already documented. Also it brings maintnense overhead. |
Member
|
@mrandrewandrade, let's close this for now. |
Member
|
I'm OK with this, but what about adding a hyperlink to https://spark.apache.org/docs/latest/sql-data-sources.html in addition to or instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added the full set of options for the format used in the DataFrameWriter method.
How was this patch tested?
It's just a trivial doc change. I tested the format options worked to prepare files in the specified format for csv, orc and text .