Skip to content

Conversation

@shahidki31
Copy link
Contributor

What changes were proposed in this pull request?

Updated the documentation about spark.ui.retainedTasks, spark.ui.retainedJobs, spark.ui.retainedStages

How was this patch tested?

NA

@shahidki31
Copy link
Contributor Author

shahidki31 commented Nov 25, 2018

Hi @srowen , Some users seems getting confused with the threshold values, is it worth to update the docs? Thanks

@SparkQA
Copy link

SparkQA commented Nov 25, 2018

Test build #99240 has finished for PR 23134 at commit ca62b7e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 25, 2018

Test build #99241 has finished for PR 23134 at commit 44d2c58.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it clarifies. Soft threshold implies it can retain more than the max. I also don't think we want to say it's definitely at least 90%. What is an example of this creating confusion?

@shahidki31
Copy link
Contributor Author

In the JIRA, when the user want retainedTasks as 60000, actually retained around 58000.
As per the code, it retained atleast 0.9*retainedTasks to retainedTasks. if we can clearly specify about the threshold, the confusion doesn't arises.
If it is okay with the documentation, I can close the PR.

@shahidki31 shahidki31 closed this Nov 25, 2018
@srowen
Copy link
Member

srowen commented Nov 25, 2018

I think the existing docs are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants