[MINOR][SQL][PYTHON] Make projection creation separate of the output in FlatMapGroupsInPandasExec#23739
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][SQL][PYTHON] Make projection creation separate of the output in FlatMapGroupsInPandasExec#23739HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #102059 has finished for PR 23739 at commit
|
Member
Author
|
retest this please |
|
Test build #102060 has finished for PR 23739 at commit
|
Member
Author
|
retest this please |
|
Test build #102062 has finished for PR 23739 at commit
|
Member
Author
|
Thanks @HeartSaVioR . Adding @BryanCutler and @icexelloss as well. |
BryanCutler
reviewed
Feb 7, 2019
sql/core/src/main/scala/org/apache/spark/sql/execution/python/FlatMapGroupsInPandasExec.scala
Show resolved
Hide resolved
HyukjinKwon
changed the title
Member
Author
|
D'oh, sorry guys, I updated the JIRA and PR. I misread it. |
Member
Author
|
Hm, let me just leave this closed. Minor style fixes are not quite encouraged anyway. I might likely touch this code soon since I am working on vectorized R native udfs (gapply and dapply). Let me fix it if I happen to touch this code later. |
Member
Author
|
BTW, thanks for reviewing this guys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The projection creation at output looks confusing. It looks like creating each projection for each record (but actually it doesn't). We should better pull it out.
How was this patch tested?
Existing tests should cover.