[MINOR]Remove unnecessary gets when getting a value from map.

[10110346]

What changes were proposed in this pull request?

Redundant get when getting a value from Map given a key.

How was this patch tested?

N/A

[HyukjinKwon]

BTW, how did you find those instances?

[10110346]

BTW, how did you find those instances?

Thanks, I found those using IntelliJ IDEA--->Analyze--->Inspect Code....

[HyukjinKwon]

I haven;t take a super close look but looks fine.

[SparkQA]

Test build #102809 has finished for PR 23901 at commit 77950e8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[vanzin]

Normally I find these changes pretty pointless. There's nothing wrong with the existing code. Unless you're actually making other changes around the code being modified here, I'd just leave things as is.

[vanzin]

Instead of just following what your IDE says, you could actually have simplified this whole block of code.

[SparkQA]

Test build #102845 has finished for PR 23901 at commit 765be91.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Yeah I agree with this kind of cleanup for Spark 3.

[srowen]

You're welcome to fix this to === while here.

[10110346]

ok, thanks

[HyukjinKwon]

I agree with @vanzin's in general to be honest - I don't think it's encouraged to fix them. I am a-okay to fix it in Spark 3 but I would like to avoid to put a lot of efforts on this.

[SparkQA]

Test build #102888 has finished for PR 23901 at commit c837686.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

I agree with the general principle of not changing trivial stuff because of merge conflicts. My logic here is: Spark 3 is a good place as back ports from 3 to 2 are pretty rare; we want to be able to touch up the code at some point; generally OK with this from newer contributors.

[srowen]

Merged to master