[SPARK-3540] Add reboot-slaves functionality to the ec2 script#2404
[SPARK-3540] Add reboot-slaves functionality to the ec2 script#2404rxin wants to merge 1 commit intoapache:masterfrom
Conversation
(cherry picked from commit 9aaad3c) Signed-off-by: Reynold Xin <rxin@apache.org>
|
QA tests have started for PR 2404 at commit
|
|
QA tests have finished for PR 2404 at commit
|
|
LGTM |
|
@ScrapCodes any idea why random public classes are being reported, even though they have nothing to do with this PR? |
|
Merging in master. Thanks. |
|
It happens because in the git diff the script compares the PR branch with master and if PR is not rebased to the tip of master. False reporting will happen. |
|
So I guess it came from the commit, da33acb. But this seems to be present in your branch. So may be I will have to dig deeper. |
Won't those changes show up as removed lines though? The script that posts these new classes filters in only added lines. |
|
Actually, I guess if a class was removed from master but not also removed from the PR fork, then that would show up as an added class. |
Tested on a real cluster.