[CORE][MINOR] Correct the comment to show heartbeat interval is configurable#24101
Closed
SongYadong wants to merge 2 commits intoapache:masterfrom
Closed
[CORE][MINOR] Correct the comment to show heartbeat interval is configurable#24101SongYadong wants to merge 2 commits intoapache:masterfrom
SongYadong wants to merge 2 commits intoapache:masterfrom
Conversation
srowen
reviewed
Mar 15, 2019
| * When an executor is unable to send heartbeats to the driver more than `HEARTBEAT_MAX_FAILURES` | ||
| * times, it should kill itself. The default value is 60. It means we will retry to send | ||
| * heartbeats about 10 minutes because the heartbeat interval is 10s. | ||
| * heartbeats about 10 minutes if the heartbeat interval is set to 10s or left default(10s). |
Member
There was a problem hiding this comment.
I think the sentence still has problems. How about: "For example, if max failures is 60 and heartbeat interval is 10s, then it will try to send heartbeats for up to 600s (10 minutes)."
Contributor
Author
There was a problem hiding this comment.
yes, it seems better. thanks ! I'will update it.
srowen
approved these changes
Mar 15, 2019
Member
|
ok to test |
|
Test build #103531 has finished for PR 24101 at commit
|
Member
|
Merged to master |
Contributor
Author
|
Thanks for review and merging. @srowen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Executor heartbeat interval is configurable by
"spark.executor.heartbeatInterval". But in a comment, heartbeat interval is presented as a constant10s. This pr tries to correct the description.How was this patch tested?
Existing unit tests.