Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Mar 25, 2019

What changes were proposed in this pull request?

Fix references to scala 2.11 in 2.4.x docs; should default to 2.12. Note 2.11 support is deprecated in 2.4.x. Note that this change isn't needed in master as it's already on 2.12 in docs by default.

How was this patch tested?

Docs build.

@srowen srowen self-assigned this Mar 25, 2019
SPARK_VERSION_SHORT: 2.4.2
SCALA_BINARY_VERSION: "2.11"
SCALA_VERSION: "2.11.12"
SCALA_BINARY_VERSION: "2.12"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these values only affect the docs, and whether we render things like "org.apache.spark:foo_2.12" in docs. It doesn't affect the code that is built.

@SparkQA
Copy link

SparkQA commented Mar 25, 2019

Test build #103926 has finished for PR 24210 at commit 6fbd432.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Note that support for Java 7, Python 2.6 and old Hadoop versions before 2.6.5 were removed as of Spark 2.2.0.
Support for Scala 2.10 was removed as of 2.3.0.
Support for Scala 2.10 was removed as of 2.3.0. Support for Scala 2.11 is deprecated as of Spark 2.4.1
and will be removed in Spark 3.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Mar 25, 2019

Yes. This is a required change for Spark 3.0.0.

BTW, @srowen , @rxin , @gatorsmile , @cloud-fan , @dbtsai . Currently, we are in this position.

  • In Apache Spark 2.4.0, Scala 2.12 was an experimental support
  • In Apache Spark 2.4.1, Scala-2.11 was deprecated in this PR.

In Apache Spark 2.4.1 ~ 2.4.3, how can we communicate to the users? I'm wondering if Scala 2.12 becomes a non-experimental support officially.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Mar 25, 2019

Also, we had better have Apache Spark JIRA for this.

@srowen
Copy link
Member Author

srowen commented Mar 25, 2019

OK I'll attach a JIRA.
I think we could call it unexperimental at this point. It's the default, in the build at least, since 2.4.0, and haven't heard of any significant issues with it. I don't know if we actually called it 'experimental' so the state here seems accurate.

@srowen srowen changed the title [MINOR][DOCS] Fix references to scala 2.11 in 2.4.x docs; Note 2.11 support is deprecated in 2.4.x [SPARK-27274][DOCS] Fix references to scala 2.11 in 2.4.x docs; Note 2.11 support is deprecated in 2.4.x Mar 25, 2019
@dongjoon-hyun
Copy link
Member

Thanks, @srowen .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27274][DOCS] Fix references to scala 2.11 in 2.4.x docs; Note 2.11 support is deprecated in 2.4.x [SPARK-27274][DOCS] Fix references to scala 2.11 in 2.4.1+ docs; Note 2.11 support is deprecated in 2.4.1+ Mar 25, 2019
@SparkQA
Copy link

SparkQA commented Mar 25, 2019

Test build #103930 has finished for PR 24210 at commit 0469cd9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Mar 26, 2019

Merged to 2.4

@srowen srowen closed this Mar 26, 2019
srowen added a commit that referenced this pull request Mar 26, 2019
… 2.11 support is deprecated in 2.4.1+

## What changes were proposed in this pull request?

Fix references to scala 2.11 in 2.4.x docs; should default to 2.12. Note 2.11 support is deprecated in 2.4.x. Note that this change isn't needed in master as it's already on 2.12 in docs by default.

## How was this patch tested?

Docs build.

Closes #24210 from srowen/Scala212docs24.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
@srowen srowen deleted the Scala212docs24 branch March 26, 2019 00:13
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
… 2.11 support is deprecated in 2.4.1+

## What changes were proposed in this pull request?

Fix references to scala 2.11 in 2.4.x docs; should default to 2.12. Note 2.11 support is deprecated in 2.4.x. Note that this change isn't needed in master as it's already on 2.12 in docs by default.

## How was this patch tested?

Docs build.

Closes apache#24210 from srowen/Scala212docs24.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 25, 2019
… 2.11 support is deprecated in 2.4.1+

## What changes were proposed in this pull request?

Fix references to scala 2.11 in 2.4.x docs; should default to 2.12. Note 2.11 support is deprecated in 2.4.x. Note that this change isn't needed in master as it's already on 2.12 in docs by default.

## How was this patch tested?

Docs build.

Closes apache#24210 from srowen/Scala212docs24.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
… 2.11 support is deprecated in 2.4.1+

## What changes were proposed in this pull request?

Fix references to scala 2.11 in 2.4.x docs; should default to 2.12. Note 2.11 support is deprecated in 2.4.x. Note that this change isn't needed in master as it's already on 2.12 in docs by default.

## How was this patch tested?

Docs build.

Closes apache#24210 from srowen/Scala212docs24.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants