Skip to content

[SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive information #24257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gatorsmile wants to merge 1 commit into from
Closed

[SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive information #24257

gatorsmile wants to merge 1 commit into from

Conversation

@gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Mar 31, 2019

What changes were proposed in this pull request?

This PR is a FollowUp of #24196. It improves the test case by using the parameters that are being used in the actual scenarios.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

gatorsmile commented Mar 31, 2019

@ninadingole @srowen

@gatorsmile gatorsmile force-pushed the followupSPARK-27244 branch from db17e75 to 07bd3ab Compare March 31, 2019 02:46
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27244][CORE][TEST] toDebugString redacts sensitive information [SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive information Mar 31, 2019
dongjoon-hyun
dongjoon-hyun approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Mar 31, 2019

Test build #104121 has finished for PR 24257 at commit 07bd3ab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Mar 31, 2019

Merged to master/2.4/2.3.

dongjoon-hyun pushed a commit that referenced this pull request Mar 31, 2019
@gatorsmile @dongjoon-hyun
[SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive i…
66dfece 
…nformation

## What changes were proposed in this pull request?
This PR is a FollowUp of #24196. It improves the test case by using the parameters that are being used in the actual scenarios.

## How was this patch tested?
N/A

Closes #24257 from gatorsmile/followupSPARK-27244.

Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 92b6f86)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun pushed a commit that referenced this pull request Mar 31, 2019
@gatorsmile @dongjoon-hyun
[SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive i…
7c0475a 
…nformation

## What changes were proposed in this pull request?
This PR is a FollowUp of #24196. It improves the test case by using the parameters that are being used in the actual scenarios.

## How was this patch tested?
N/A

Closes #24257 from gatorsmile/followupSPARK-27244.

Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 92b6f86)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@SparkQA
Copy link

SparkQA commented Mar 31, 2019

Test build #104126 has finished for PR 24257 at commit 07bd3ab.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 31, 2019

Test build #104125 has finished for PR 24257 at commit db17e75.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • abstract class BaseSubqueryExec extends SparkPlan
  • case class SubqueryExec(name: String, child: SparkPlan)
  • case class ReusedSubqueryExec(child: BaseSubqueryExec)
  • abstract class ExecSubqueryExpression extends PlanExpression[BaseSubqueryExec]

kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
@gatorsmile @kai-chi
[SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive i…
b05f32f 
…nformation

## What changes were proposed in this pull request?
This PR is a FollowUp of apache#24196. It improves the test case by using the parameters that are being used in the actual scenarios.

## How was this patch tested?
N/A

Closes apache#24257 from gatorsmile/followupSPARK-27244.

Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 92b6f86)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 25, 2019
@gatorsmile @kai-chi
[SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive i…
224c73f 
…nformation

## What changes were proposed in this pull request?
This PR is a FollowUp of apache#24196. It improves the test case by using the parameters that are being used in the actual scenarios.

## How was this patch tested?
N/A

Closes apache#24257 from gatorsmile/followupSPARK-27244.

Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 92b6f86)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
@gatorsmile @kai-chi
[SPARK-27244][CORE][TEST][FOLLOWUP] toDebugString redacts sensitive i…
e027748 
…nformation

## What changes were proposed in this pull request?
This PR is a FollowUp of apache#24196. It improves the test case by using the parameters that are being used in the actual scenarios.

## How was this patch tested?
N/A

Closes apache#24257 from gatorsmile/followupSPARK-27244.

Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 92b6f86)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gatorsmile @SparkQA @dongjoon-hyun @srowen