[SPARK-27531][SQL] Improve EXPLAIN DESC TABLE to show the input parameters of the command.#24427
Closed
dilipbiswal wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-27531][SQL] Improve EXPLAIN DESC TABLE to show the input parameters of the command.#24427dilipbiswal wants to merge 1 commit intoapache:masterfrom
EXPLAIN DESC TABLE to show the input parameters of the command.#24427dilipbiswal wants to merge 1 commit intoapache:masterfrom
Conversation
…w the inputs to the command
dilipbiswal
changed the title
EXPLAIN DESC TABLE to show the input parameters of the command.
|
Test build #104780 has finished for PR 24427 at commit
|
dongjoon-hyun
changed the title
EXPLAIN DESC TABLE to show the input parameters of the command.EXPLAIN DESC TABLE to show the input parameters of the command.
| * Determine if a plan should be explained at all. | ||
| */ | ||
| protected def isExplainableStatement(plan: LogicalPlan): Boolean = plan match { | ||
| case _: DescribeTableCommand => false |
Member
There was a problem hiding this comment.
Hi, @hvanhovell .
This was introduced at Spark 2.0.0 by SPARK-13713 . Can we remove this at 3.0.0?
Member
|
Retest this please. |
|
Test build #104811 has finished for PR 24427 at commit
|
dongjoon-hyun
approved these changes
Apr 22, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you, @dilipbiswal .
Contributor
Author
|
Thanks a LOT @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently "EXPLAIN DESC TABLE" is special cased and outputs a single row relation as following.
Current output:
This is not consistent with how we handle explain processing for other commands. In this PR, the inconsistency is handled by removing the special handling for "describe table".
After change:
How was this patch tested?
Added new tests in SQLQueryTestSuite.