[SPARK-27556][BUILD] Exclude com.zaxxer:HikariCP-java7 from hadoop-yarn-server-web-proxy#24450
Closed
wangyum wants to merge 1 commit intoapache:masterfrom
wangyum:SPARK-27556
Closed
[SPARK-27556][BUILD] Exclude com.zaxxer:HikariCP-java7 from hadoop-yarn-server-web-proxy#24450wangyum wants to merge 1 commit intoapache:masterfrom wangyum:SPARK-27556
wangyum wants to merge 1 commit intoapache:masterfrom
wangyum:SPARK-27556
Conversation
srowen
approved these changes
Apr 24, 2019
Member
srowen
left a comment
There was a problem hiding this comment.
Do we just not need it so it's safe to exclude? Looks like it's a connection pool. If it's just used by YARN, OK I'm guessing this is fine.
|
Test build #104873 has finished for PR 24450 at commit
|
Member
|
Oh OK the point is that these aren't the same artifact; one is |
Member
|
Merged to master |
lwwmanning
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 19, 2020
…rn-server-web-proxy ## What changes were proposed in this pull request? There are two HikariCP packages in classpath when building with `-Phive -Pyarn -Phadoop-3.2`. The HikariCP dependency tree: ``` [INFO] | +- org.apache.hadoop:hadoop-yarn-server-web-proxy:jar:3.2.0:compile [INFO] | | \- org.apache.hadoop:hadoop-yarn-server-common:jar:3.2.0:compile [INFO] | | +- org.apache.hadoop:hadoop-yarn-registry:jar:3.2.0:compile [INFO] | | | \- commons-daemon:commons-daemon:jar:1.0.13:compile [INFO] | | +- org.apache.geronimo.specs:geronimo-jcache_1.0_spec:jar:1.0-alpha-1:compile [INFO] | | +- org.ehcache:ehcache:jar:3.3.1:compile [INFO] | | +- com.zaxxer:HikariCP-java7:jar:2.4.12:compile ``` ``` [INFO] +- org.apache.hive:hive-metastore:jar:2.3.4:compile [INFO] | +- javolution:javolution:jar:5.5.1:compile [INFO] | +- com.google.protobuf:protobuf-java:jar:2.5.0:compile [INFO] | +- com.jolbox:bonecp:jar:0.8.0.RELEASE:compile [INFO] | +- com.zaxxer:HikariCP:jar:2.5.1:compile ``` This pr exclude `com.zaxxer:HikariCP-java7` from `hadoop-yarn-server-web-proxy`. ## How was this patch tested? manual tests Closes apache#24450 from wangyum/SPARK-27556. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are two HikariCP packages in classpath when building with
-Phive -Pyarn -Phadoop-3.2.The HikariCP dependency tree:
This pr exclude
com.zaxxer:HikariCP-java7fromhadoop-yarn-server-web-proxy.How was this patch tested?
manual tests