[SPARK-27618][SQL][FOLLOW-UP] Unnecessary access to externalCatalog#24511
Closed
gatorsmile wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-27618][SQL][FOLLOW-UP] Unnecessary access to externalCatalog#24511gatorsmile wants to merge 2 commits intoapache:masterfrom
gatorsmile wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #105072 has finished for PR 24511 at commit
|
dongjoon-hyun
changed the title
| val catalog = new SessionCatalog(externCatalog, FunctionRegistry.builtin, conf) | ||
| catalog.createDatabase( | ||
| CatalogDatabase("default", "", new URI("loc"), Map.empty), | ||
| ignoreIfExists = false) |
Member
There was a problem hiding this comment.
The above three line is required to prevent NoSuchDatabaseException in the previous code before 181d190.
| val func = | ||
| Alias(UnresolvedFunction("sum", Seq(UnresolvedAttribute("a")), isDistinct = false), "s")() | ||
| val plan = Project(Seq(func), testRelation) | ||
| analyzer.execute(plan) |
dongjoon-hyun
approved these changes
May 2, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
It's great to have this test coverage and this example. Thanks, @gatorsmile .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to add test cases for ensuring that we do not have unnecessary access to externalCatalog.
In the future, we can follow these examples to improve our test coverage in this area.
How was this patch tested?
N/A