Skip to content

[SPARK-27706][SQL][WEBUI] Add SQL metrics of numOutputRows for BroadcastExchangeExec#24603

Closed
cxzl25 wants to merge 3 commits intoapache:masterfrom
cxzl25:add_numOutputRows_BroadcastExchangeExec
Closed

[SPARK-27706][SQL][WEBUI] Add SQL metrics of numOutputRows for BroadcastExchangeExec#24603
cxzl25 wants to merge 3 commits intoapache:masterfrom
cxzl25:add_numOutputRows_BroadcastExchangeExec

Conversation

@cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented May 14, 2019

What changes were proposed in this pull request?

Add SQL metrics of numOutputRows for BroadcastExchangeExec

How was this patch tested?

@cxzl25
Copy link
Contributor Author

cxzl25 commented May 14, 2019

Current UI
image

Add SQL metrics of numOutputRows
image

number of output rows: 0

You can clearly see the amount of BroadcastExchange output, especially if there is no data output after calculation.

cxzl25 added 2 commits May 20, 2019 14:39
# Conflicts:
#	sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
@cxzl25
Copy link
Contributor Author

cxzl25 commented May 20, 2019

@cloud-fan
Can help to see if this change is necessary, if you have free time
If necessary, help trigger the test

@xy2953396112
Copy link
Contributor

I think it looks good

@cxzl25
Copy link
Contributor Author

cxzl25 commented May 29, 2019

@dongjoon-hyun
Can you help me review on this PR?

@cloud-fan
Copy link
Contributor

ok to test

@cloud-fan
Copy link
Contributor

cloud-fan commented May 29, 2019

usually we don't add row count metrics to operators that do not change numRows. Why didn't the Filter operator in your screenshot report row count?

@SparkQA
Copy link

SparkQA commented May 29, 2019

Test build #105919 has finished for PR 24603 at commit f230282.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cxzl25
Copy link
Contributor Author

cxzl25 commented May 30, 2019

ok, I know, it is really not necessary.

@cxzl25 cxzl25 closed this May 30, 2019
@cxzl25 cxzl25 deleted the add_numOutputRows_BroadcastExchangeExec branch May 30, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants