[MINOR][DOCS] Tighten up some key links to the project and download pages to use HTTPS#24665
Closed
srowen wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][DOCS] Tighten up some key links to the project and download pages to use HTTPS#24665srowen wants to merge 1 commit intoapache:masterfrom
srowen wants to merge 1 commit intoapache:masterfrom
Conversation
felixcheung
approved these changes
May 21, 2019
| To build SparkR on Windows, the following steps are required | ||
|
|
||
| 1. Install R (>= 3.1) and [Rtools](http://cran.r-project.org/bin/windows/Rtools/). Make sure to | ||
| 1. Install R (>= 3.1) and [Rtools](https://cloud.r-project.org/bin/windows/Rtools/). Make sure to |
Member
There was a problem hiding this comment.
In this PR, cran -> cloud(here and https://github.com/apache/spark/pull/24665/files#diff-e700812356511df02cda7d3ccd38ca02R241) seems to be the only changes to a better mirror site. +1.
Member
Author
There was a problem hiding this comment.
Yeah I could have included this with the other change too. This one is not a 'functional' change so I put it here.
dongjoon-hyun
approved these changes
May 21, 2019
|
Test build #105623 has finished for PR 24665 at commit
|
dongjoon-hyun
approved these changes
May 21, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tighten up some key links to the project and download pages to use HTTPS
How was this patch tested?
N/A