[SPARK-27862][BUILD] Move to json4s 3.6.6 #24736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add scala-xml 1.2.0
wangyum
reviewed
May 29, 2019
|
Test build #4786 has finished for PR 24736 at commit
|
srowen
approved these changes
May 29, 2019
pom.xml
Outdated
| <groupId>org.json4s</groupId> | ||
| <artifactId>json4s-jackson_${scala.binary.version}</artifactId> | ||
| <version>3.5.3</version> | ||
| <version>3.6.5</version> |
Member
There was a problem hiding this comment.
Hi, @igreenfield . The following is the JIRA description. Since 3.6.6 is already out, could you describe the reason why we don't use 3.6.6 into the PR description? Your previous comment (#24729 (comment)) would be enough.
it will be very good to upgrade to newer version
Author
There was a problem hiding this comment.
I will upgrade to latest version, I think it is better
dev/deps/spark-deps-hadoop-2.7
Outdated
| json4s-ast_2.12-3.6.5.jar | ||
| json4s-core_2.12-3.6.5.jar | ||
| json4s-jackson_2.12-3.6.5.jar | ||
| json4s-scalap_2.12-3.6.5.jar |
Member
There was a problem hiding this comment.
You should regenerate this, too.
Member
|
Also, please update the title and PR description accordingly. |
igreenfield
changed the title
dongjoon-hyun
changed the title
Member
|
Retest this please. |
|
Test build #105972 has finished for PR 24736 at commit
|
dongjoon-hyun
changed the title
srowen
approved these changes
May 30, 2019
dongjoon-hyun
approved these changes
May 30, 2019
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move to json4s version 3.6.6
Add scala-xml 1.2.0
How was this patch tested?
Pass the Jenkins