[SPARK-27760][CORE] Spark resources - change user resource config from .count to .amount#24810
Closed
tgravescs wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-27760][CORE] Spark resources - change user resource config from .count to .amount#24810tgravescs wants to merge 3 commits intoapache:masterfrom
tgravescs wants to merge 3 commits intoapache:masterfrom
Conversation
tgravescs
changed the title
tgravescs
changed the title
Contributor
Author
jiangxb1987
reviewed
Jun 5, 2019
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceRequestHelper.scala
Outdated
Show resolved
Hide resolved
|
Test build #106212 has finished for PR 24810 at commit
|
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
Outdated
Show resolved
Hide resolved
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Jun 5, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM except two nit comments on test case names.
|
Test build #106215 has finished for PR 24810 at commit
|
Contributor
Author
|
Updated, thanks for the reviews, I'll let this run through jenkins and commit if everything looks good. |
|
Test build #106243 has finished for PR 24810 at commit
|
Contributor
Author
|
very odd test faiure, it has 4 executors instead of 3 which has nothing to do with this change just running local-cluster mode. I'll kick it again. |
Contributor
Author
|
test this please |
Member
|
Thank you for updating, @tgravescs . Yes. The failure looks weird. Let's see the new Jenkins result. |
|
Test build #106245 has finished for PR 24810 at commit
|
Contributor
Author
|
merged to master |
emanuelebardelli
pushed a commit
to emanuelebardelli/spark
that referenced
this pull request
Jun 15, 2019
…m .count to .amount
## What changes were proposed in this pull request?
Change the resource config spark.{executor/driver}.resource.{resourceName}.count to .amount to allow future usage of containing both a count and a unit. Right now we only support counts - # of gpus for instance, but in the future we may want to support units for things like memory - 25G. I think making the user only have to specify a single config .amount is better then making them specify 2 separate configs of a .count and then a .unit. Change it now since its a user facing config.
Amount also matches how the spark on yarn configs are setup.
## How was this patch tested?
Unit tests and manually verified on yarn and local cluster mode
Closes apache#24810 from tgravescs/SPARK-27760-amount.
Authored-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the resource config spark.{executor/driver}.resource.{resourceName}.count to .amount to allow future usage of containing both a count and a unit. Right now we only support counts - # of gpus for instance, but in the future we may want to support units for things like memory - 25G. I think making the user only have to specify a single config .amount is better then making them specify 2 separate configs of a .count and then a .unit. Change it now since its a user facing config.
Amount also matches how the spark on yarn configs are setup.
How was this patch tested?
Unit tests and manually verified on yarn and local cluster mode