Skip to content

Comments

Merge asof join skeleton#24941

Closed
jaebahk wants to merge 1 commit intoapache:masterfrom
jaebahk:merge_asof
Closed

Merge asof join skeleton#24941
jaebahk wants to merge 1 commit intoapache:masterfrom
jaebahk:merge_asof

Conversation

@jaebahk
Copy link

@jaebahk jaebahk commented Jun 23, 2019

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review https://spark.apache.org/contributing.html before opening a pull request.

@jaebahk
Copy link
Author

jaebahk commented Jun 23, 2019

@icexelloss

@gatorsmile
Copy link
Member

@icexelloss Could you help guide @jaewanbahk about the PR contribution? https://spark.apache.org/contributing.html

@gatorsmile
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Jun 24, 2019

Test build #106810 has finished for PR 24941 at commit 438300a.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class MergeAsOf(
  • case class MergeAsOfJoinExec(

@icexelloss
Copy link
Contributor

@jaewanbahk Let's not create PR against Master. Please close this one and create one against your fork.

@jaebahk jaebahk closed this Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants