Potential error of message construction of SCC#2507
Conversation
Hi, According to the [paper](http://ilpubs.stanford.edu:8090/1077/3/p535-salihoglu.pdf), I think the message passing condition written in line 78 should be ```scala e.srcAttr._1 < e.dstAttr._1 ``` instead of the previous one, because the `srcAttr._1` and `dstAttr._1` are the `colorId` in **Forward-Traversal** phase, as written in the paper.
|
Can one of the admins verify this patch? |
Contributor
|
Hey can you create a JIRA issue for this? Also, can you add [GraphX] to the title? Thanks /cc @ankurdave |
Contributor
|
@weilan007 Thanks for the PR! I think this is the same as #2486 (https://issues.apache.org/jira/browse/SPARK-3635). |
Author
|
Thanks! @ankurdave , I will close it. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
According to the paper, I think the message passing condition written in line 78 should be
e.srcAttr._1 < e.dstAttr._1instead of the previous one, because the
srcAttr._1anddstAttr._1are thecolorIdin Forward-Traversal phase, as written in the paper.