Skip to content

[Docs] logNormalGraph missing partition parameter#2523

Closed
malterb wants to merge 1 commit intoapache:masterfrom
malterb:patch-1
Closed

[Docs] logNormalGraph missing partition parameter#2523
malterb wants to merge 1 commit intoapache:masterfrom
malterb:patch-1

Conversation

@malterb
Copy link

@malterb malterb commented Sep 24, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Can one of the admins verify this patch?

@ankurdave
Copy link
Contributor

Thanks! Just a minor thing -- it would be good to use the argument name as follows:

 val graph: Graph[Double, Int] =
   GraphGenerators.logNormalGraph(sc, numVertices = 100,
     numEParts = sc.defaultParallelism).mapVertices( (id, _) => id.toDouble )

ok to test (though it's only a doc change)

@andrewor14
Copy link
Contributor

Hey @elmalto could you add [Docs] to the title?

@malterb malterb changed the title logNormalGraph missing partition parameter [Docs] logNormalGraph missing partition parameter Oct 7, 2014
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't help myself to pedantry while you're here: space before sc please!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, also no space before )

@malterb
Copy link
Author

malterb commented Oct 7, 2014

For some reason I cannot change the pull request itself

@JoshRosen
Copy link
Contributor

@elmalto It looks like GitHub says that this PR was opened from "unknown repository", which might explain why you're not able to update its code. If that's the case, could you close this PR and open a new one?

@malterb malterb closed this Oct 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants