[Docs] logNormalGraph missing partition parameter#2523
Closed
malterb wants to merge 1 commit intoapache:masterfrom
malterb:patch-1
Closed
[Docs] logNormalGraph missing partition parameter#2523malterb wants to merge 1 commit intoapache:masterfrom malterb:patch-1
malterb wants to merge 1 commit intoapache:masterfrom
malterb:patch-1
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
Thanks! Just a minor thing -- it would be good to use the argument name as follows: val graph: Graph[Double, Int] =
GraphGenerators.logNormalGraph(sc, numVertices = 100,
numEParts = sc.defaultParallelism).mapVertices( (id, _) => id.toDouble )ok to test (though it's only a doc change) |
Contributor
|
Hey @elmalto could you add |
Member
There was a problem hiding this comment.
I can't help myself to pedantry while you're here: space before sc please!
Contributor
There was a problem hiding this comment.
+1, also no space before )
Author
|
For some reason I cannot change the pull request itself |
Contributor
|
@elmalto It looks like GitHub says that this PR was opened from "unknown repository", which might explain why you're not able to update its code. If that's the case, could you close this PR and open a new one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.