[MINOR][PYTHON] Use _memory_limit to get worker memory conf in rdd.py#25273
Closed
WangGuangxin wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][PYTHON] Use _memory_limit to get worker memory conf in rdd.py#25273WangGuangxin wants to merge 1 commit intoapache:masterfrom
_memory_limit to get worker memory conf in rdd.py#25273WangGuangxin wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @HyukjinKwon |
Member
|
ok to test |
dongjoon-hyun
changed the title
_memory_limit to get worker memory conf
dongjoon-hyun
requested changes
Jul 27, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Hi, @WangGuangxin . According to the commit history, this can be applied to branch-2.4/2.3. Could you make a JIRA issue and use it for traceability?
|
Test build #108254 has finished for PR 25273 at commit
|
dongjoon-hyun
changed the title
_memory_limit to get worker memory conf_memory_limit to get worker memory conf in rdd.py
Member
|
Hmm. Never mind. Let's consider only |
dongjoon-hyun
approved these changes
Jul 27, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master. Thank you, @WangGuangxin .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace duplicate code by function
_memory_limitHow was this patch tested?
Existing UTs