-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-28585][WebUI] Improve WebUI DAG information: Add extra info to rdd from spark plan #25319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9f71b18
04a3962
a72de71
29d135c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -616,8 +616,13 @@ case class UnionExec(children: Seq[SparkPlan]) extends SparkPlan { | |
| } | ||
| } | ||
|
|
||
| protected override def doExecute(): RDD[InternalRow] = | ||
| def addExtraInfo: RDD[InternalRow] => RDD[InternalRow] = { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's your plan to add this info for all Exec nodes? Add the function into SparkPlan?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Different nodes must implement diferent versions of addExtra info because the structure of the nodes and the interesting informatión to show is different. |
||
| _.setExtraInfo(s"Union(${output.mkString(", ")})") | ||
| } | ||
|
|
||
| protected override def doExecute(): RDD[InternalRow] = addExtraInfo { | ||
| sparkContext.union(children.map(_.execute())) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this because of one more "\n" added in https://github.com/apache/spark/pull/25319/files#diff-61a3c327c6093db76e3c77280ff71ae5R233?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the reason