[SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction/alterFunction #25394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own if the function no more exsist, but incase of temporary proper msg was shown saying temporary function does not exsist. Correcting the error message while dropping Permanent function.
maropu
reviewed
Aug 10, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
Show resolved
Hide resolved
Member
|
ok to test |
|
Test build #108900 has finished for PR 25394 at commit
|
maropu
changed the title
HyukjinKwon
reviewed
Aug 15, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
Show resolved
Hide resolved
…wn if the function no more exsist, but incase of temporary proper msg was shown saying temporary function does not exsist. Correcting the error message while dropping Permanent function.
|
Test build #109187 has finished for PR 25394 at commit
|
Member
|
retest this please |
HyukjinKwon
approved these changes
Aug 16, 2019
maropu
approved these changes
Aug 16, 2019
|
Test build #109204 has finished for PR 25394 at commit
|
maropu
changed the title
Member
|
Thanks! Merged to master |
Member
|
@PavithraRamachandran Thanks for your contribution! I added you to the Spark contribution group to assign SPARK-28671 to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before Fix
When a non existent permanent function is dropped, generic NoSuchFunctionException was thrown.- which printed "This function is neither a registered temporary function nor a permanent function registered in the database" .
This creates a ambiguity when a temp function in the same name exist.
After Fix
NoSuchPermanentFunctionException will be thrown, which will print
"NoSuchPermanentFunctionException:Function not found in database "
How was this patch tested?
Unit test was run and corrected the UT.