[SPARK-28677][WEBUI] "Select All" checkbox in StagePage doesn't work properly

[sarutak]

What changes were proposed in this pull request?

In StagePage, only the first optional column (Scheduler Delay, in this case) appears even though "Select All" checkbox is checked.

The cause is that wrong method is used to manipulate multiple columns. columns should have been used but column was used.
I've fixed this issue by replacing the column with columns.

How was this patch tested?

Confirmed behavior of the check-box.

[sarutak]

CC: @pgandhi999 and @tgravescs

[SparkQA]

Test build #108877 has finished for PR 25397 at commit 27d2991.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[sarutak]

retest this please.

[SparkQA]

Test build #108879 has finished for PR 25397 at commit 27d2991.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[pgandhi999]

@sarutak Thank you for catching the bug. Interestingly, I am only able to reproduce the bug in Spark 3.0, it works fine in Spark 2.3 and 2.4. Are you also able to reproduce the bug in 2.3 and 2.4?

[srowen]

OK by me if it's a clean UI fix.

[pgandhi999]

NIT: Could you rename the variable to something like allColumns to have more clarity?

[sarutak]

@pgandhi999

Thank you for catching the bug. Interestingly, I am only able to reproduce the bug in Spark 3.0, it works fine in Spark 2.3 and 2.4. Are you also able to reproduce the bug in 2.3 and 2.4?

2.3 and 2.4 use additional-metrics.js rather than stagepage.js for the checkboxes.
I think that's why only 3.0 has this issue.

[pgandhi999]

2.3 and 2.4 use additional-metrics.js rather than stagepage.js for the checkboxes.
I think that's why only 3.0 has this issue.

Ah, that makes sense. Thank you.

[pgandhi999]

LGTM +1

[tgravescs]

"2.3 and 2.4 use additional-metrics.js rather than stagepage.js for the checkboxes.
I think that's why only 3.0 has this issue."

Can you please explain this in more details so we have it documented what really book it? Please also update the description to say what you change and ideally why it was broken.

[sarutak]

Can you please explain this in more details so we have it documented what really book it? Please

stagepage.js is not present in 2.3 and 2.4. This bug has been brought by stagepage.js which is merged into master.
The cause is that wrong method is used to manipulate multiple columns. columns should have been used but column was used.

[SparkQA]

Test build #108882 has finished for PR 25397 at commit 2f7f558.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[tgravescs]

changes look good. thanks @sarutak

[srowen]

Merged to master