[SPARK-28243][PYSPARK][ML][FOLLOW-UP] Move Python DecisionTreeParams to regression.py#25406
[SPARK-28243][PYSPARK][ML][FOLLOW-UP] Move Python DecisionTreeParams to regression.py#25406huaxingao wants to merge 1 commit intoapache:masterfrom
Conversation
|
I move |
|
Test build #108927 has finished for PR 25406 at commit
|
|
@huaxingao Do you update the |
|
Yes, |
zhengruifeng
left a comment
There was a problem hiding this comment.
I am Ok with this modification, however the DecisionTreeParams in the py side is still not sync with the scala side. We can leave this confilict alone, and make them in sync in the future.
srowen
left a comment
There was a problem hiding this comment.
Eh, yeah this is my fault for not realizing this is how the parameters are defined in some cases. I imagine there are other sync problems. It'd be great to re-sync them, though I do wonder whether this mechanism is worth it. That can happen later if you're willing. I think this is OK.
|
Merged to master |
|
Thanks @srowen @zhengruifeng |
What changes were proposed in this pull request?
Leave
shared.pyuntouched. Move PythonDecisionTreeParamstoregression.pyHow was this patch tested?
Use existing tests