[SPARK-28017][SPARK-28656][SQL][FOLLOW-UP] Restore comments in date.sql#25422
Closed
MaxGekk wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-28017][SPARK-28656][SQL][FOLLOW-UP] Restore comments in date.sql#25422MaxGekk wants to merge 1 commit intoapache:masterfrom
MaxGekk wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@dongjoon-hyun Please, take a look at the PR. |
dongjoon-hyun
approved these changes
Aug 12, 2019
Member
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you, @MaxGekk .
To reviewers,
this PR restores the comments in date.sql which are ignored during the testing. In Jenkins, it's already tested.
[info] - pgSQL/date.sql (13 seconds, 348 milliseconds)
In addition, I tested this PR to regenerate the golden files locally. And, there is no difference at result.
[info] - pgSQL/date.sql (2 seconds, 685 milliseconds)
|
Test build #108983 has finished for PR 25422 at commit
|
Member
|
The PySpark failure is irrelevant to this one.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Restored comments in
date.sqlremoved by 924d794 and 997d153 . The comments was introduced by 51379b7 .How was this patch tested?
By re-running
date.sqlvia:$ build/sbt "sql/test-only *SQLQueryTestSuite -- -z date.sql"