Skip to content

[SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference#25540

Closed
huaxingao wants to merge 6 commits intoapache:masterfrom
huaxingao:spark-28830
Closed

[SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference#25540
huaxingao wants to merge 6 commits intoapache:masterfrom
huaxingao:spark-28830

Conversation

@huaxingao
Copy link
Contributor

@huaxingao huaxingao commented Aug 21, 2019 •
edited
Loading

What changes were proposed in this pull request?

Document UNCACHE TABLE statement in SQL Reference

Why are the changes needed?

To complete SQL Reference

Does this PR introduce any user-facing change?

Yes.

After change:

image

How was this patch tested?

Tested using jykyll build --serve

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109498 has finished for PR 25540 at commit 7c9ab22.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Aug 21, 2019 •
edited
Loading

@huaxingao Could you please attach a screenshot of the page ?

srowen
srowen requested changes Aug 21, 2019
View reviewed changes
docs/sql-ref-syntax-aux-cache-uncache-table.md Outdated

**This page is under construction**
### Description
Drop all cached entries associated with the table from the RDD cache
Copy link
Member

@srowen srowen Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to say this just undoes a CACHE TABLE? or if I create a DataFrame from the table, and cache it, would it uncache that too? I actually don't know, just making sure the 'all cached entries' means what we intend. Whatever the answer it might bear a little more explanation.

@srowen
Copy link
Member

srowen commented Aug 21, 2019

PS you might look at the other similar PRs to add these docs to try to harmonize the style and format a little bit. They're pretty similar. That can mean reviewing others' changes.

@SparkQA
Copy link

SparkQA commented Aug 22, 2019

Test build #109537 has finished for PR 25540 at commit b3d2e6c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed Aug 22, 2019
View reviewed changes
docs/sql-ref-syntax-aux-cache-uncache-table.md Outdated

**This page is under construction**
### Description
Removes the specified table from the in-memory cache.
Copy link
Member

@srowen srowen Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, in-memory or on-disk, just to be technically correct.

@SparkQA
Copy link

SparkQA commented Aug 22, 2019

Test build #109550 has finished for PR 25540 at commit ca03005.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 4, 2019

Test build #110151 has finished for PR 25540 at commit 56c94a9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dilipbiswal
dilipbiswal reviewed Sep 4, 2019
View reviewed changes
docs/sql-ref-syntax-aux-cache-uncache-table.md Outdated

**This page is under construction**
### Description
`UNCACHE TABLE` removes the entries and associated data from the in-memory and/or on-disk cache for the given table. The
Copy link
Contributor

@dilipbiswal dilipbiswal Sep 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : for a ?

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Sep 4, 2019

LGTM

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Sep 4, 2019

cc @gatorsmile

@SparkQA
Copy link

SparkQA commented Sep 5, 2019

Test build #110154 has finished for PR 25540 at commit a3b3f86.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile gatorsmile closed this in e4f7002 Sep 5, 2019
@gatorsmile
Copy link
Member

gatorsmile commented Sep 5, 2019 •
edited
Loading

LGTM

Thanks! Merged to master.

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Sep 5, 2019

retest this please

@huaxingao
Copy link
Contributor Author

huaxingao commented Sep 5, 2019

Thanks @dilipbiswal @srowen @gatorsmile

@huaxingao huaxingao deleted the spark-28830 branch September 9, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen requested changes

@dilipbiswal dilipbiswal dilipbiswal left review comments

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@huaxingao @SparkQA @dilipbiswal @srowen @gatorsmile @dongjoon-hyun