[SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core #25610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Aug 28, 2019
| if (tables.containsKey(ident)) { | ||
| throw new TableAlreadyExistsException(ident) | ||
| } | ||
|
|
||
| if (partitions.nonEmpty) { |
Contributor
Author
There was a problem hiding this comment.
the sql/core version supports partitions, so the merged version should support partitions as well.
cloud-fan
commented
Aug 28, 2019
| import org.apache.spark.sql.util.CaseInsensitiveStringMap | ||
|
|
||
| // this is currently in the spark-sql module because the read and write API is not in catalyst | ||
| // TODO(rdblue): when the v2 source API is in catalyst, merge with TestTableCatalog/InMemoryTable |
Contributor
Author
There was a problem hiding this comment.
This TODO is completed in this PR.
Contributor
Author
|
Test build #109868 has finished for PR 25610 at commit
|
|
Test build #109869 has finished for PR 25610 at commit
|
|
Test build #109870 has finished for PR 25610 at commit
|
|
Test build #109894 has finished for PR 25610 at commit
|
Contributor
|
+1 |
Contributor
|
Merged to master. |
Member
|
Yey! Congratulation, @rdblue !!! 😄 |
Contributor
|
Thanks! |
Contributor
Author
|
@rdblue congrats and thanks for merging my PR! Hopefully this is your first Spark PR merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are 2 in-memory
TableCatalogandTableimplementations for testing, in sql/catalyst and sql/core. This PR merges them.After merging, there are 3 classes:
InMemoryTableInMemoryTableCatalogStagingInMemoryTableCatalogFor better maintainability, these 3 classes are put in 3 different files.
Why are the changes needed?
reduce duplicated code
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A