[SPARK-28958][ML][PYSPARK][WIP] pyspark.ml function parity#25662
Closed
zhengruifeng wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-28958][ML][PYSPARK][WIP] pyspark.ml function parity#25662zhengruifeng wants to merge 4 commits intoapache:masterfrom
zhengruifeng wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Since I remove the setters generated by |
Contributor
Author
|
I just test the modification in pyspark repl, and record the updated places in the attachment in the ticket |
|
Test build #110039 has finished for PR 25662 at commit
|
Contributor
Author
|
This PR is too large, I need to divide it into small ones in some way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, remove setters generated by _shared_params_code_gen.py;
2, add common abstract classes like the side side, such as JavaPredictor/JavaClassificationModel/JavaProbabilisticClassifier;
3, for each alg, add its param trait, such as LinearSVCParams;
4, since sharedParam do not have setters, we need to add them in right places;
Why are the changes needed?
yes, some methods in estimators and models in the py side are changed
How was this patch tested?
I test them in pyspark repl for now