[SPARK-23519][SQL][2.4] Create view should work from query with duplicate output columns #25733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
cloud-fan
changed the title
Contributor
|
ok to test |
|
Test build #110363 has finished for PR 25733 at commit
|
Member
|
retest this please |
|
Test build #110373 has finished for PR 25733 at commit
|
Contributor
|
thanks, merging to 2.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Sep 10, 2019
…cate output columns **What changes were proposed in this pull request?** Backporting the pullrequest [25570](#25570) to branch-2.4 Moving the call for checkColumnNameDuplication out of generateViewProperties. This way we can choose ifcheckColumnNameDuplication will be performed on analyzed or aliased plan without having to pass an additional argument(aliasedPlan) to generateViewProperties. Before the pr column name duplication was performed on the query output of below sql(c1, c1) and the pr makes it perform check on the user provided schema of view definition(c1, c2) **Why are the changes needed?** Changes are to fix SPARK-23519 bug. Below queries would cause an exception. This pr fixes them and also added a test case. `CREATE TABLE t23519 AS SELECT 1 AS c1 CREATE VIEW v23519 (c1, c2) AS SELECT c1, c1 FROM t23519` Does this PR introduce any user-facing change? No **How was this patch tested?** new unit test added in SQLViewSuite Closes #25733 from hem1891/SPARK-23519-backport-to-2.4. Lead-authored-by: hemanth meka <hmeka@tibco.com> Co-authored-by: hem1891 <hem1891@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
Hi， @cloud-fan ，I need your help to solve a problem, which is the 'with as select' statement in spark SQL. How can I not execute the 'create view' statement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backporting the pullrequest 25570 to branch-2.4
Moving the call for checkColumnNameDuplication out of generateViewProperties. This way we can choose ifcheckColumnNameDuplication will be performed on analyzed or aliased plan without having to pass an additional argument(aliasedPlan) to generateViewProperties.
Before the pr column name duplication was performed on the query output of below sql(c1, c1) and the pr makes it perform check on the user provided schema of view definition(c1, c2)
Why are the changes needed?
Changes are to fix SPARK-23519 bug. Below queries would cause an exception. This pr fixes them and also added a test case.
CREATE TABLE t23519 AS SELECT 1 AS c1 CREATE VIEW v23519 (c1, c2) AS SELECT c1, c1 FROM t23519Does this PR introduce any user-facing change?
No
How was this patch tested?
new unit test added in SQLViewSuite