[SPARK-29030][SQL] Simplify lookupV2Relation

[jzhuge]

What changes were proposed in this pull request?

Simplify the return type for lookupV2Relation which makes the 3 callers more straightforward.

How was this patch tested?

Existing unit tests.

[SparkQA]

Test build #110364 has finished for PR 25735 at commit 855a8cf.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• implicit class MultipartIdentifierHelper(parts: Seq[String])

[dongjoon-hyun]

Hi, @jzhuge . Could you file a JIRA issue for this?

[jzhuge]

@dongjoon-hyun @HyukjinKwon Sure thing. Thanks for acting so quickly :)

[jzhuge]

Hi @brkyvz, do the changes look ok to you?

[SparkQA]

Test build #110382 has finished for PR 25735 at commit a96e390.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• implicit class MultipartIdentifierHelper(parts: Seq[String])

[brkyvz]

maybe use catalogManager.v2SessionCatalog to be consistent with lookupV2Relation?

[jzhuge]

Good suggestion. This may inspire an even further simplification. Let me explore and report back.

[brkyvz]

retest this please

[SparkQA]

Test build #110488 has finished for PR 25735 at commit a96e390.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• implicit class MultipartIdentifierHelper(parts: Seq[String])

[SparkQA]

Test build #110544 has finished for PR 25735 at commit f92a258.

• This patch fails Scala style tests.
• This patch does not merge cleanly.
• This patch adds no public classes.

[jzhuge]

rebasing

[SparkQA]

Test build #110546 has finished for PR 25735 at commit 58037d2.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• implicit class MultipartIdentifierHelper(parts: Seq[String])

[jzhuge]

Looking at the test failures

[SparkQA]

Test build #110564 has finished for PR 25735 at commit a276e06.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[jzhuge]

retest please

[brkyvz]

@jzhuge Can you please rebase this?

[jzhuge]

Sure

…

On Tue, Sep 17, 2019 at 11:19 AM Burak Yavuz ***@***.***> wrote: @jzhuge <https://github.com/jzhuge> Can you please rebase this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25735?email_source=notifications&email_token=AAOL5JBWSRMSV5YU7DHXJELQKENT7A5CNFSM4IU6O3M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD65N22I#issuecomment-532340073>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOL5JGFMP2BVB55ZIFM2NDQKENT7ANCNFSM4IU6O3MQ> .

-- John Zhuge

[SparkQA]

Test build #110846 has finished for PR 25735 at commit eb14b7f.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• implicit class MultipartIdentifierHelper(parts: Seq[String])

[brkyvz]

This LGTM. Merging to master. Thanks @jzhuge !

[jzhuge]

Thanks @brkyvz !