[SPARK-28939][SQL][FOLLOWUP] Avoid useless Properties#25742
Closed
mgaido91 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-28939][SQL][FOLLOWUP] Avoid useless Properties#25742mgaido91 wants to merge 1 commit intoapache:masterfrom
mgaido91 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
cloud-fan
approved these changes
Sep 10, 2019
maropu
approved these changes
Sep 10, 2019
maropu
changed the title
Member
|
Thanks! Merged to master. |
|
Test build #110415 has finished for PR 25742 at commit
|
Member
|
oh, I didn't notice that the tests not finished..., but, that failuare is not related to this pr. |
Member
|
retest this please |
Member
|
Just in case, I've checked that the Jenkins tests passed in https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test/job/spark-master-test-maven-hadoop-2.7/6838/ |
Member
|
Late LGTM. Thank you all! |
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
### What changes were proposed in this pull request? Removes useless `Properties` created according to hvanhovell 's suggestion. ### Why are the changes needed? Avoid useless code. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? existing UTs Closes apache#25742 from mgaido91/SPARK-28939_followup. Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removes useless
Propertiescreated according to @hvanhovell 's suggestion.Why are the changes needed?
Avoid useless code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
existing UTs